Skip to content

Give the flat-side accidentals their own unicode spellings (AI) #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscuthbert merged 1 commit into from
Sep 1, 2026
+19 −4
Merged

Give the flat-side accidentals their own unicode spellings (AI) #2021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions music21/pitch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Authors: Michael Scott Asato Cuthbert
# Christopher Ariza
#
# Copyright: Copyright © 2008-2019 Michael Scott Asato Cuthbert
# Copyright: Copyright © 2008-2026 Michael Scott Asato Cuthbert
# License: BSD, see license.txt
# ------------------------------------------------------------------------------
'''
Expand Down Expand Up @@ -120,11 +120,11 @@
('#', '\u266f'),
('~', chr(0x1d132)), # 1D132
('----', chr(0x1d12b) + chr(0x1d12b)),
('---', '\u266D'),
('---', '\u266D' + chr(0x1d12b)),
('--', chr(0x1d12b)),
('-`', '\u266D' + chr(0x1d132)),
('-`', '\u266D' + chr(0x1d133)), # 1D133
('-', '\u266D'),
('`', chr(0x1d132)), # 1D132; raised flat: 1D12C
('`', chr(0x1d133)), # 1D133; raised flat: 1D12C
('', '\u266e'), # natural
])

Expand Down Expand Up @@ -5444,6 +5444,21 @@ def testCopyAndDeepcopy(self) -> None:
from music21.test.commonTest import testCopyAll
testCopyAll(self, globals())

def testUnicodeDistinguishesEveryAccidental(self) -> None:
'''
Each accidental gets its own unicode spelling, and the flat side
mirrors the sharp side. AI-assisted (Claude).
'''
spellings = {name: Accidental(name).unicode for name in accidentalNameToModifier}
self.assertEqual(len(set(spellings.values())), len(spellings))
# QUARTER TONE FLAT, not QUARTER TONE SHARP
self.assertEqual(spellings['half-flat'], '\U0001d133')
self.assertEqual(spellings['one-and-a-half-flat'], '♭\U0001d133')
# three flats is a flat plus a double flat, as three sharps is a sharp
# plus a double sharp
self.assertEqual(spellings['triple-flat'], '♭\U0001d12b')
self.assertEqual(spellings['triple-sharp'], '♯\U0001d12a')


# define presented order in documentation
_DOC_ORDER = [Pitch, Accidental, Microtone]
Expand Down
Loading