Skip to content

improve: [1181] データ管理画面でショートカットキーを管理対象に追加 - #2262

Merged
cwtickle merged 1 commit into
developfrom
feature/1181-shortcut-mgt
Oct 12, 2026
Merged

cwtickle merged 1 commit into
developfrom
feature/1181-shortcut-mgt

Conversation

@cwtickle

Copy link
Copy Markdown
Owner

🔨 変更内容 / Details of Changes

1. improve: データ管理画面でショートカットキーを管理対象に追加

  • データ管理画面の管理対象に、ショートカットキーを追加しました。
  • 他の項目と同様に、キー別の項目削除時に合わせてクリアされます。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. 処理上影響は無いですが、他の処理との整合のため対応します。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

@cwtickle cwtickle added the func03:DataManagement データ管理機能 label Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3dfa1bd-a40c-4700-ad06-27b00833f8d0

📥 Commits

Reviewing files that changed from the base of the PR and between 1a29eb6 and 5b38157.


📒 Files selected for processing (1)
  • js/lib/danoni_constants.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Improvements
    • Shortcut settings are now included with other key-specific settings, allowing them to be handled as part of the same settings storage category. No other user-facing changes are included in this release.

Walkthrough

The key-specific storage category list now includes shortcut.

Changes

Key Settings Storage

Layer / File(s) Summary
Update key-specific storage categories
js/lib/danoni_constants.js
g_settings.keyStorages now includes shortcut.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature


Merge Risk: ⚪ Minimal · up to 5b381

Key-specific deletion now clears the corresponding shortcut settings, including extra-key storage, without disturbing other categories. No material merge risk remains.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the addition of shortcut keys to the data management screen. This matches the main change.
Description check Passed The description explains that shortcut keys are added to the managed items and cleared with key-specific item deletion. This matches the changeset.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cwtickle
cwtickle merged commit e9f2eee into develop Oct 12, 2026
4 checks passed
@cwtickle
cwtickle deleted the feature/1181-shortcut-mgt branch October 12, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

func03:DataManagement データ管理機能

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant