Skip to content

feat: [1182] キーボードプレビューでカラーグループごとに配色できる機能を追加 - #2263

Merged
cwtickle merged 1 commit into
developfrom
feature/1182-group-color-preview
Oct 12, 2026
Merged

cwtickle merged 1 commit into
developfrom
feature/1182-group-color-preview

Conversation

@cwtickle

@cwtickle cwtickle commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

🔨 変更内容 / Details of Changes

1. feat: キーボードプレビューでカラーグループごとに配色できる機能を追加

  • キーコンフィグ画面のキーボードプレビューで、カラーグループごとに配色する機能を追加しました。
  • デフォルトの表示は残しつつ、「Group Color」をクリックすると表示が切り替わります。
  • カーソル選択中のキーは枠色が白になります。
  • g_dfColorObj.setColorType2の色をベースに割り当てます。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. 表示のわかりやすさのため。

📷 スクリーンショット / Screenshot

image

📝 その他コメント / Other Comments

@cwtickle cwtickle added the func11:KeyConfig キーコンフィグ、キー定義関係 label Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3388a6c9-ff53-4981-9b6e-3c9374b53b4e

📥 Commits

Reviewing files that changed from the base of the PR and between e9f2eee and 9fab55a.


📒 Files selected for processing (2)
  • js/lib/danoni_constants.js
  • js/lib/keyconfig.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Summary

Summary by CodeRabbit

  • New Features
    • Added a lane-coloring mode to the keyboard preview, with a toggle and color legend to show lane groups and their key assignments.
    • The preview highlights keys associated with the current cursor lane and updates as you move the cursor or change color groups.
    • Added “Group Color” as a label for the lane-coloring option.
📝 Summary

Walkthrough

The keyboard configuration preview now supports lane coloring. It displays keys by lane assignment, provides a toggle and legend, and refreshes when the color group or cursor changes.

Changes

Keyboard Preview Lane Coloring

Layer / File(s) Summary
Lane assignment map
js/lib/keyconfig.js
The preview builds a map of lane assignments for the displayed key group. It deduplicates entries, marks assignments for the current lane, limits each key to three entries, and clears the map on disposal.
Lane-colored key rendering
js/lib/keyconfig.js
The preview renders lane assignments as colored key segments and adds lane-specific legend styles. Shortcut keys retain their dedicated styling.
Lane mode controls and refreshes
js/lib/danoni_constants.js, js/lib/keyconfig.js
The preview adds a Group Color toggle. It refreshes after color-group changes and, when lane coloring is enabled, after cursor movement.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature


Merge Risk: ⚪ Minimal · up to 9fab5

This adds an optional group-color mode to the keyboard preview on the Key Config screen, and the default display is unchanged. No actionable merge-blocking risk was identified.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description directly explains the new keyboard preview color-group feature, its toggle behavior, and its purpose.
Title check Passed The title clearly and concisely identifies the addition of color-group coloring in the keyboard preview.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cwtickle cwtickle added the Layout Changes ラベルやボタンなどのレイアウト変更を伴う修正 label Oct 12, 2026
@cwtickle
cwtickle merged commit f352606 into develop Oct 12, 2026
4 checks passed
@cwtickle
cwtickle deleted the feature/1182-group-color-preview branch October 12, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

func11:KeyConfig キーコンフィグ、キー定義関係 Layout Changes ラベルやボタンなどのレイアウト変更を伴う修正

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant