Skip to content

refactor: [1184] プレイ画面周りのコード整理 - #2267

Merged
cwtickle merged 1 commit into
developfrom
feature/1184-cr-main
Oct 18, 2026
Merged

cwtickle merged 1 commit into
developfrom
feature/1184-cr-main

Conversation

@cwtickle

Copy link
Copy Markdown
Owner

🔨 変更内容 / Details of Changes

1. refactor: プレイ画面周りのコード整理

  • プレイ画面周りの内部関数名や、紛らわしい関数を整理しました。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. メンテナンスをしやすくするため。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

@cwtickle cwtickle added func20:Main プレイ画面全般 code-refactoring labels Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0a0e9e58-7cd0-413f-8e75-67f704ae38c4
📥 Commits

Reviewing files that changed from the base of the PR and between 07192e7 and 3ca232d.

📒 Files selected for processing: 2
  • js/lib/danoni_constants.js
  • js/lib/mainWindow.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Improvements
    • The options display now adjusts its width based on the screen size.
    • Arrow judgment and freeze-arrow handling have been updated while preserving the existing counters, labels, and display settings.

The pull request adjusts option sprite sizing and updates judgment-counter creation and arrow processing in mainWindow.js. It also changes lyric font-size parsing and fade-flag clearing.

Changes: Option Sprite Sizing

Layer / File(s) Summary
Set option sprite width
js/lib/danoni_constants.js
The option sprite width now uses half the screen width plus 225 pixels.

Judgment Counter and Arrow Processing

Layer / File(s) Summary
Create judgment counter labels
js/lib/mainWindow.js
Counter labels are created directly with createDivCss2Label. The makeCounterSymbol helper is removed.
Update arrow judgment processing
js/lib/mainWindow.js
movArrow decrements the arrow counter before calling judgeMotion. Freeze-arrow helpers are renamed, and movFrzArrow calls the renamed helpers.

Lyric and Fade Handling

Layer / File(s) Summary
Update lyric and fade handling
js/lib/mainWindow.js
Lyric font-size parsing passes the matched text directly to setIntVal. Fade completion stores each flag key in a local variable before checking and clearing the flag.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 3ca23

The play-screen refactor preserves the reviewed counter behavior, and no material regression is identified. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies a refactor of code around the play screen. It matches the main changes, including internal function renaming and code organization.
Description check Passed The description explains that the pull request organizes internal function names and clarifies functions around the play screen to improve maintenance. It is related to the changeset.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ast-grep (0.45.3)
js/lib/danoni_constants.js

ast-grep timed out on this file

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cwtickle
cwtickle merged commit 52e0d92 into develop Oct 18, 2026
4 checks passed
@cwtickle
cwtickle deleted the feature/1184-cr-main branch October 19, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-refactoring func20:Main プレイ画面全般

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant