Skip to content

ci: bump to cbindgen v0.29.3 - #382

Draft
cyphar wants to merge 1 commit into
mainfrom
cbindgen-0.29.3
Draft

ci: bump to cbindgen v0.29.3#382
cyphar wants to merge 1 commit into
mainfrom
cbindgen-0.29.3

Conversation

@cyphar

@cyphar cyphar commented May 30, 2026

Copy link
Copy Markdown
Owner

This version added support for C23 fixed-type enum syntax, which caused
our CI to break as the output of cbindgen changed. To avoid this
happening in the future, lock the cbindgen version in CI.

Signed-off-by: Aleksa Sarai aleksa@amutable.com

@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cyphar

cyphar commented May 30, 2026

Copy link
Copy Markdown
Owner Author

I opened this issue to help show the issue with mozilla/cbindgen#1156. For now, we will need to pin an older version.

@cyphar
cyphar marked this pull request as draft May 30, 2026 07:38
This version added support for C23 fixed-type enum syntax, which caused
our CI to break as the output of cbindgen changed. To avoid this
happening in the future, lock the cbindgen version in CI.

Signed-off-by: Aleksa Sarai <aleksa@amutable.com>
@cyphar
cyphar force-pushed the cbindgen-0.29.3 branch from b9ff6a6 to 1df2794 Compare May 30, 2026 07:43
@martinpitt

Copy link
Copy Markdown

#408 is vaguely related to this. However, this PR is blocked on the Python bindings. However, the Go failure would not have shown up here, as CI runs on Ubuntu latest (i.e. 24.04 LTS) whose gcc still defaults to gcc17. But that this only true as long as emilio's suggestion in mozilla/cbindgen#1156 of "defaulting to true with the ifdefs removed altogether" does not land. If/once it actually does, generated headers use the enum spelling unconditionally, so so type ProcBase C.pathrs_proc_base_t breaks on every compiler and -std=gnu17 stops being a workaround for anyone, and it will also start failing on our ubuntu-latest CI runs. Then #408 becomes much more urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants