Document that merge-conflicted PRs silently swallow review-surface commands - #67
Merged
Merged
Conversation
…mmands GitHub runs pull_request_review(_comment) workflows against the PR's merge ref; while a conflict makes that ref uncreatable, no workflow run is created at all — no ack, no skipped run. Bit for real on dev#122: a /build in a review summary vanished after another PR's merge conflicted the branch. The conversation surface (issue_comment) is unaffected, so the note points at the two ways out. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_review/pull_request_review_commentevents while the PR is merge-conflicted — the merge ref those workflows run against cannot be created, so commands submitted with a review vanish with no ack and no skipped run.issue_commentnever uses the merge ref).Observed on d3mlabs/dev#122: a
/buildin a review summary was swallowed after another PR's merge conflicted the branch six minutes earlier.Test plan
Made with Cursor