The ACP session catalog is the model-name source of truth (#84) - #85
Merged
Merged
Conversation
Model selection goes through ACP session/set_model; agent --list-models ids are a different naming domain, yet the job log printed them as 'the menu of valid model names' and the template/docs named them the source of truth — which is exactly what stranded three repo configs (and the first diagnosis) on the ceremony's live /build. - resolve_model's failure now dumps names AND modelIds (the modelId is where thinking/effort variants live — the error is the discovery surface for the exact string to pin). - The workflow's --list-models log group is deleted; nobody needs the catalog until resolution fails, and when it fails the error is self-sufficient. - Template, README, and architecture.md now name the session catalog as the source of truth. Closes #84. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84.
Model selection goes through ACP `session/set_model`, but the job log printed `agent --list-models` as "the menu of valid model names" and the template/docs named it the source of truth — a different naming domain (suffix ids like `claude-fable-5-high` vs plain ACP names + parameterized modelIds). That mismatch stranded three repo configs at the ACP switch and misdirected the first live-fire diagnosis (cellbound-3d#161 / dev#166 / plans#43).
Per the scoping discussion: non-ACP is a retired transport, so no suffix-id tolerance — the loud failure just has to dump the right catalog.
Test-first: the unknown-handle test now asserts the modelId appears in the error.
Made with Cursor