You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From review discussion on #133 (thread): bin/release.rb has grown into a ~250-line procedural script of top-level methods and constants, and #133 added more (two lockstep formulas via FORMULA_PATHS, per-formula url+sha surgery). It deserves a proper refactor rather than more accretion.
Candidate shape:
Extract cohesive steps (version bump, tag/push, GitHub release, formula update) into small objects or a class per concern, following the repo's typed, constructor-injected conventions where the polyglot ruby -x bootstrap allows.
Typed errors instead of bare abort strings; tests for the pure parts (version parsing/increment, formula substitution) using real files in temp dirs.
From review discussion on #133 (thread): bin/release.rb has grown into a ~250-line procedural script of top-level methods and constants, and #133 added more (two lockstep formulas via
FORMULA_PATHS, per-formula url+sha surgery). It deserves a proper refactor rather than more accretion.Candidate shape:
ruby -xbootstrap allows.abortstrings; tests for the pure parts (version parsing/increment, formula substitution) using real files in temp dirs.dev releasewith pluggable publishers #70 (builtindev releasewith pluggable publishers) — if that lands, this script may be absorbed rather than refactored in place.Out of scope for #133 per review; tracked here.