Skip to content

BuildContainerTest leaks host state: 4 tests fail on any bootstrapped agent host #165

Description

@JPDuchesne

Discovered while running the suite on the Mac right after the plans#36 ceremony bootstrapped it as an agent host.

Four `BuildContainerTest` tests hard-code `/.dev/...` path expectations (e.g. asserting `/.dev/engines/unreal-engine-css:/ue` in the docker run command), but production `DataRoot` resolves to `/Users/Shared/dev` whenever the shared root exists. The tests pass on machines without the shared root (CI, un-bootstrapped dev boxes) and fail on any bootstrapped agent host:

  • `test_docker_run_command_expands_~_in_volume_host_paths`
  • `test_build_contexts_from_lockfile_returns_build-group_install_dirs`
  • `test_build_contexts_from_lockfile_reads_integration-nested_lockfiles`
  • `test_build_contexts_from_lockfile_points_at_the_version-keyed_subdir_when_a_version_is_locked`

Reproduced on main (unrelated to any in-flight branch). The fix is test hygiene: the tests should pin the data root (inject it, or point it at a tmpdir) instead of reading whatever the host happens to have — expectations should not depend on whether the machine has been through the agent-host ceremony.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions