tc.rb: distinguish 'tapioca could not run' from stale RBIs - #163
Merged
Conversation
The verify step discarded tapioca's stderr and reported every failure as 'RBI files are out of date — run dev rbi'. In a shell without the project env (agent/CI shells get no cd-triggered shadowenv hook), the rbenv shim can't resolve tapioca at all — and the misleading message sends the reader chasing RBI regeneration instead of shell activation. Now an exit-127/command-not-found failure names the real problem and the two correct invocations (dev tc, shadowenv exec). Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The first fix special-cased exit 127 / command-not-found, but bundler
missing-gem errors, ruby-pin mismatches, and tapioca crashes would still
misreport as stale RBIs. Invert the check: positively detect tapioca's
verdict on stderr ('RBI files are out-of-date'); every other failure
surfaces its real output, with the shadowenv activation hint kept for
the command-not-found shape.
Verified live: activated run green; removed-RBI run reports stale with
tapioca's reason; bare half-activated shell reports the rbenv shim
error with the activation hint.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RBI verify step discarded tapioca's stderr and reported every failure as "RBI files are out of date. Run: dev rbi". In a shell without the project environment (agent and CI shells get no cd-triggered shadowenv hook), the rbenv shim can't resolve
tapiocaat all (exit 127) — and the misleading message sends the reader off regenerating RBIs when the fix is shell activation. This burned real time again today.Now a could-not-run failure reports the actual stderr and the two correct invocations:
Verified live both ways: green under
shadowenv exec, honest diagnosis from a bare shell. Root-cause fix per the capture-learning doctrine — the coping rule ("always shadowenv exec") already lives in the org ruby-toolchain skill; what was missing was the tool telling the truth.Made with Cursor