fix(wails3): drive the stack with the wails3 CLI, not a Taskfile target - #82
Conversation
Task (taskfile.dev) is its own build orchestrator and no part of Wails.
Threading a Taskfile target name through this action put another
project's tool in the Wails stack's vocabulary, and made the caller name
an internal detail — `darwin:package` — that Wails already has a verb
for.
The premise in the old description was wrong: "there is no `wails build`
invocation to compose". There is. `wails3 build` and `wails3 package` are
both real, and internally they route through the project's own build
description with GOOS passed in, so the CLI already does the dispatch
this action was reaching past it to do by hand. The input is now
`wails3-command`, taking `build` or `package` and nothing else — an
unknown verb fails here, naming the caller, rather than reaching wails3
as a subcommand it does not have.
That also drops the step installing the Task binary: wails3 runs the
build through its own embedded runner, so nothing here needs task on
PATH.
The contract check gains the case that let this ship broken. A composite
action referencing ${{ inputs.X }} it does not itself declare gets the
empty string, silently — and the forwarding check could not see it,
because it only asks whether a name a file declares is passed on.
Forwarding an input the file never declared satisfies it while passing
nothing, which is how the previous attempt at this repaired one hop of
the chain, reported sound, and stayed severed at the next.
Co-Authored-By: Virgil <virgil@lethean.io>
|
Warning Review limit reached
Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Task (taskfile.dev) is its own build orchestrator and no part of Wails. Threading a Taskfile target name through this action put another project's tool into the Wails stack's vocabulary, and made the caller name an internal detail —
darwin:package— that Wails already has a verb for.The premise in the old description was wrong:
There is.
wails3 buildandwails3 packageare both real, and internally they route through the project's own build description withGOOSpassed in — so the CLI already does the dispatch this action was reaching past it to do by hand.The input is
wails3-commandnow, takingbuildorpackageand nothing else. An unknown verb fails here, naming the caller, rather than reaching wails3 as a subcommand it does not have. This also drops the step that installed the Task binary: wails3 runs the build through its own embedded runner.The contract check gains the case that let this ship broken
A composite action referencing
${{ inputs.X }}it does not itself declare gets the empty string, silently. The forwarding check could not see it — it only asks whether a name a file declares is passed on, so forwarding an input the file never declared satisfies it while passing nothing.That is exactly how the previous attempt repaired one hop of the chain, reported sound, and stayed severed at the next. Verified against the real bug:
🤖 Generated with Claude Code
Co-Authored-By: Virgil virgil@lethean.io