Repository navigation
feat(plugin-basic-ui): support horizontal safe area insets (FEP-2885) - #756
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 506b33b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (8)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying stackflow-demo with
|
| Latest commit: |
506b33b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1ba0fb3.stackflow-demo.pages.dev |
| Branch Preview URL: | https://feature-fep-2885.stackflow-demo.pages.dev |
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stackflow-docs | 506b33b | Commit Preview URL | Oct 06 2026, 08:47 AM |
ENvironmentSet
force-pushed
the
feature/fep-2885
branch
from
October 6, 2026 08:43
84c1902 to
506b33b
Compare
ENvironmentSet
marked this pull request as ready for review
October 6, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppScreen previously ignored horizontal safe area insets, allowing its content and app bar controls to extend into display cutouts. Apply left and right insets to both themes, matching the behavior introduced in SEED #2223.
Horizontal safe area support intentionally changes the default content width on devices with left or right insets. Consumers can use the documented full-bleed wrapper to extend selected content to the screen edges.
Validation on the branch rebased onto main including #758:
The earlier deployed preview exposed the demo wrappers bypassing padding. The new preview for commit 506b33b passes all 26 layout observations and eight runtime checks. All current CI checks passed. Link resolver setup comes from the already merged #758 and is not duplicated in this PR.
FEP-2885