Skip to content

feat(plugin-basic-ui): unify default AppBar height to 56px - #757

Merged
ENvironmentSet merged 2 commits into
mainfrom
fix/basic-ui-app-bar-height
Oct 6, 2026
Merged

ENvironmentSet merged 2 commits into
mainfrom
fix/basic-ui-app-bar-height

Conversation

@ENvironmentSet

@ENvironmentSet ENvironmentSet commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Set the default AppBar height and minimum height to 56px for both Cupertino and Android. Previously, Cupertino used 2.75rem and Android used 3.5rem, so both heights depended on the root font size.

AppScreen content spacing follows the same height variable. Top safe area spacing and custom height options continue to apply. Includes a minor changeset for @stackflow/plugin-basic-ui.

Validation:

  • Built the demo and its workspace dependencies with yarn ultra -r --filter '+@stackflow/demo' build.
  • Passed plugin-basic-ui typecheck, Biome, and diff checks.
  • Checked both themes' generated CSS in Chromium at 390 × 844: root font sizes of 10px, 16px, and 20px all produce 56px height, minimum height, and content offset.
  • A 47px top safe area produces 103px total spacing; a custom 64px height produces 111px with that inset.
  • Native iOS/Android WebView rendering was not verified.

@changeset-bot

changeset-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8868a0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackflow/plugin-basic-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: daangn/stackflow/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 22ebef00-afba-4aaa-adac-2915040c61a7
📥 Commits

Reviewing files that changed from the base of the PR and between 7636750 and 8868a0b.

📒 Files selected for processing (2)
  • .changeset/unify-basic-ui-app-bar-height.md
  • extensions/plugin-basic-ui/src/basicUIPlugin.css.ts
 _____________________________
< I wish to make a complaint. >
 -----------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying stackflow-demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8868a0b
Status:⚡️  Build in progress...

View logs

@pkg-pr-new

pkg-pr-new Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
  • @stackflow/demo

    yarn add https://pkg.pr.new/@stackflow/plugin-basic-ui@757.tgz
    

commit: 8868a0b

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
🔵 In progress
View logs
stackflow-docs 8868a0b Oct 06 2026, 08:14 AM

@ENvironmentSet ENvironmentSet changed the title fix(plugin-basic-ui): unify default AppBar height to 56px feat(plugin-basic-ui): unify default AppBar height to 56px Oct 6, 2026
@ENvironmentSet
ENvironmentSet marked this pull request as ready for review October 6, 2026 08:17
@ENvironmentSet
ENvironmentSet merged commit 8c6f6ac into main Oct 6, 2026
9 of 12 checks passed
@ENvironmentSet
ENvironmentSet deleted the fix/basic-ui-app-bar-height branch October 6, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant