Repository navigation
fix: sample voxelgrid points independently of DataFrame index - #370
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The documented
pointsDataFrame selection workflow preserves row labels, but the nearest and highest voxelgrid samplers use those labels as.ilocpositions. A valid point selection can therefore raiseIndexError: positional indexers are out-of-boundsinstead of returning a sample.For example, for either sampler:
Change
Use a locally reset index for the grouping/index selection in both samplers, so the selected indices are positions. This does not reset the caller's point index or change the sampling algorithm. Add a public-API regression comparing the selected cloud with the same cloud indexed from zero.
Validation
Windows, Python 3.12.13, NumPy 2.2.6, pandas 2.2.3, SciPy 1.15.3:
8368c6a; the two regression cases pass with this change.git diff --checkpasses.VoxelGrid#369) and four tests usingsample is DataFrame; those are not changed here.