perf(compose): optimize OnboardingScreen UI runtime performance - #853
perf(compose): optimize OnboardingScreen UI runtime performance#853yacosta738 wants to merge 1 commit into
Conversation
- Define top-level constants for shapes to avoid redundant allocations. - Implement 'remember' for expensive Brush and Modifier chains. - Refactor 'onboardingLayoutModifier' as a Composable for better memoization. - Optimize 'FuturisticProgressIndicator' loop and background logic.
Deploying corvus with
|
| Latest commit: |
2a9e323
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eaf505c6.corvus-42x.pages.dev |
| Branch Preview URL: | https://perf-onboarding-ui-183406732.corvus-42x.pages.dev |
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
This PR optimizes the OnboardingScreen UI in the Compose Multiplatform app by addressing common performance bottlenecks related to redundant object allocations and missing memoization.
Key changes:
onboardingLayoutModifierinto a@Composablehelper that usesrememberto cache its complex Modifier chain and vertical gradient Brush.rememberblocks inOnboardingIconDisplayto cache linear and radial gradients.FuturisticProgressIndicatorby moving the primary gradient calculation outside therepeatloop and replacing redundant 2-color horizontal gradients with efficient solid color backgrounds for inactive states.These improvements significantly reduce GC pressure and main-thread overhead during onboarding animations and state transitions.
PR created automatically by Jules for task 18340673293902191336 started by @yacosta738