Skip to content

Adapt the 001636 and 001754 notebooks to the re-converted files - #215

Draft
bendichter wants to merge 1 commit into
fix-001636-001754-notebooksfrom
adapt-001636-001754-to-reconverted-data
Draft

bendichter wants to merge 1 commit into
fix-001636-001754-notebooksfrom
adapt-001636-001754-to-reconverted-data

Conversation

@bendichter

Copy link
Copy Markdown
Member

Waiting on release. Do not merge until new versions of 001636 and 001754 that contain the re-converted files are published. Then set dandiset_version in the five notebooks to those versions (they read "draft" for now, marked with a TODO) and mark this ready for review.

Stacked on #214, which pins these notebooks to the current published versions; the diff here is only the changes the re-converted files need. When #214 merges, this PR retargets to master.

  • 001636 (all four notebooks): the files re-uploaded on 2026-10-28 use NWB core 2.11, and their cached ndx-hed 0.3.0 extends the core 2.11 type DurationVectorData. requirements.in replaces the pynwb<4/hdmf<5 cap with pynwb>=4.2, and the re-lock moves pynwb 3.1.3 → 4.2.0 and hdmf 4.3.1 → 6.2.0; no other pins change.
  • 001754 (001754_demo): the re-converted file (2026-10-14) renamed the rate_maps columns session_type → epoch_name and cell_number → cluster_id, and stores unvisited bins as NaN in place of the −900 sentinel. The rate map lookup cell uses the new names.

Tested against the current draft files: antidromic_detection_tutorial, turner_m1_usage and 001754_demo execute end to end (the 001754 comparison still matches all 26 cells). turner_m1_peth and turner_m1_glm were run with pynwb 4.2.0 against the published files; CI here covers them on draft.

🤖 Generated with Claude Code

The October re-uploads of 001636 use NWB core 2.11, so the 001636 group
moves from pynwb 3.1.3 to 4.2.0 (hdmf 4.3.1 to 6.2.0). The re-converted
001754 file renamed the rate_maps columns (session_type -> epoch_name,
cell_number -> cluster_id) and stores unvisited bins as NaN, so the rate
map lookup uses the new names and drops the -900 sentinel handling.

The notebooks read "draft" until a release with these files is published.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions Bot added a commit that referenced this pull request Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Index page preview

A preview of the generated index.html has been deployed for this PR:

View preview

Last updated: commit 2fbc71d1ea06895219f2c1fb02f08020c4e6f9cb

github-actions Bot added a commit that referenced this pull request Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Executed notebooks

CI executes the notebooks changed in this PR through a Jupyter kernel and publishes each one, with its outputs, as soon as it finishes. Links appear below as notebooks complete; an hourglass means the notebook is still running.

5 of 5 finished. Commit 2fbc71d. The executed copies live only in the preview and are removed when the PR closes; nothing is committed to the branch.

github-actions Bot added a commit that referenced this pull request Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant