Repository navigation
Adapt the 001636 and 001754 notebooks to the re-converted files - #215
Draft
bendichter wants to merge 1 commit into
Draft
bendichter wants to merge 1 commit into
bendichter wants to merge 1 commit into
Conversation
The October re-uploads of 001636 use NWB core 2.11, so the 001636 group moves from pynwb 3.1.3 to 4.2.0 (hdmf 4.3.1 to 6.2.0). The re-converted 001754 file renamed the rate_maps columns (session_type -> epoch_name, cell_number -> cluster_id) and stores unvisited bins as NaN, so the rate map lookup uses the new names and drops the -900 sentinel handling. The notebooks read "draft" until a release with these files is published. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Index page previewA preview of the generated Last updated: commit |
Contributor
Executed notebooksCI executes the notebooks changed in this PR through a Jupyter kernel and publishes each one, with its outputs, as soon as it finishes. Links appear below as notebooks complete; an hourglass means the notebook is still running.
5 of 5 finished. Commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting on release. Do not merge until new versions of 001636 and 001754 that contain the re-converted files are published. Then set
dandiset_versionin the five notebooks to those versions (they read"draft"for now, marked with a TODO) and mark this ready for review.Stacked on #214, which pins these notebooks to the current published versions; the diff here is only the changes the re-converted files need. When #214 merges, this PR retargets to
master.ndx-hed0.3.0 extends the core 2.11 typeDurationVectorData.requirements.inreplaces thepynwb<4/hdmf<5cap withpynwb>=4.2, and the re-lock moves pynwb 3.1.3 → 4.2.0 and hdmf 4.3.1 → 6.2.0; no other pins change.001754_demo): the re-converted file (2026-10-14) renamed therate_mapscolumnssession_type→epoch_nameandcell_number→cluster_id, and stores unvisited bins as NaN in place of the −900 sentinel. The rate map lookup cell uses the new names.Tested against the current draft files:
antidromic_detection_tutorial,turner_m1_usageand001754_demoexecute end to end (the 001754 comparison still matches all 26 cells).turner_m1_pethandturner_m1_glmwere run with pynwb 4.2.0 against the published files; CI here covers them on draft.🤖 Generated with Claude Code