Skip to content
This repository was archived by the owner on Nov 14, 2020. It is now read-only.
This repository was archived by the owner on Nov 14, 2020. It is now read-only.

SentryModule.forRoot does not allow any dynamic configuration #8

Description

@jeremypele

For angular aot requirements, a direct string would work correctly
e.g => SentryModule.forRoot({ dsn: 'abc123' }),

but any const, function, getter would break the instanciation
e.g => SentryModule.forRoot({ dsn: AppConfig.sentryDSN }),

Would be cool to have something like TranslateModule for instance where you can provide a factory

TranslateModule.forRoot({
      loader: {
        provide: TranslateLoader,
        useFactory: translateLoaderFactory,
        deps: [Http],
      },
    }),

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions