Repository navigation
fix(release): keep checksums.txt byte-exact in candidate evidence.json - #391
Merged
danielhanold merged 4 commits intoOct 5, 2026
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-10-05-release-candidate-evidence-json-drops-the-trailing-newline-f.md
Read checksums.txt with jq --rawfile instead of a shell command substitution, which stripped the trailing newline and broke the release protocol's byte-equality check between evidence.json and checksums.txt.
danielhanold
force-pushed
the
fix/release-candidate-evidence-json-drops-the-trailing-newline-f
branch
from
October 5, 2026 10:55
17c53eb to
d6742e5
Compare
danielhanold
deleted the
fix/release-candidate-evidence-json-drops-the-trailing-newline-f
branch
October 5, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read
checksums.txtwithjq --rawfilein the release-candidate workflow's "Assemble the evidence JSON" step, soevidence.json'schecksums_txtis byte-equal to the bundle file (trailing newline included). The old shell command substitution stripped the newline and tripped the release protocol's Phase 2 byte-equality check.Proof: a one-off harness ran the step's real body on a sample file;
jq -j .checksums_txt evidence.json | cmp - checksums.txtfailed before the edit and passed after (with and without a trailing newline). Details in the results file.Review
Lean-tier whole-branch review: no findings.
↩ Change 0524 — Release-candidate evidence.json drops the trailing newline from its checksums copy
command: go run ./cmd/docket development test
result: green
head_sha: d6742e5
ran_at: 2026-10-05T10:54:52Z