Repository navigation
refactor: share the JSON-key rules between internal/cli and internal/app - #392
Merged
danielhanold merged 5 commits intoOct 5, 2026
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-10-05-share-the-json-key-rules-between-internal-cli-and-internal-a.md
danielhanold
deleted the
refactor/share-the-json-key-rules-between-internal-cli-and-internal-a
branch
October 5, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the JSON-key walk into one place:
internal/appexportsRequestJSONKeys, built on a shared walk thatrequiredJSONKeysalso uses (filtered todocket:"required"fields). The CLI's duplicateinternal/cli/requestkeys.gois deleted, its two unit tests move tointernal/app, and the call sites inchange.goandjsonfile_production_test.gocallapp.RequestJSONKeys. The two comments that pointed at the old CLI copy now name the shared function. No change in behavior.Review
Whole-branch review (standard tier): clean, no findings.
Build evidence
command: go run ./cmd/docket development test
result: green
head_sha: 7d9c9fa
ran_at: 2026-10-05T10:18:28Z