Repository navigation
fix(repository): configure-tests takes the test command as input - #395
Merged
danielhanold merged 16 commits intoOct 5, 2026
Merged
danielhanold merged 16 commits into
danielhanold merged 16 commits into
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-10-05-repository-init-writes-gate-off-and-configure-tests-then-ref.md
…verify
Review finding (important): configure-tests --command overwrote existing
leaves via planOwnerBlock, whose line range under-reports block scalars and
shares a line with a flow-style owner, so a folded/literal test_command left
continuation lines behind and build: {gate: "off"} lost its build: key.
renderOwnerPairs now re-parses the edited bytes (verifyOwnerPairs) and refuses,
file untouched, unless build and finalize hold exactly the desired pairs and
every other setting survives.
… off (review finding)" This reverts commit fad21d6.
… cannot verify" This reverts commit 3e4b6b0.
…e cannot verify" This reverts commit 5384f83.
…n off (review finding)" This reverts commit 1b8519c.
danielhanold
force-pushed
the
fix/repository-init-writes-gate-off-and-configure-tests-then-ref
branch
from
October 5, 2026 14:08
6d2eb10 to
0b2326d
Compare
danielhanold
deleted the
fix/repository-init-writes-gate-off-and-configure-tests-then-ref
branch
October 5, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↩ Change 0526 — repository configure-tests takes the test command as input
Summary
docket repository configure-tests --command "<cmd>"setsbuild.gate/finalize.gatetolocalwith that command (pending, unstaged.docket.ymledit; idempotent; refuses empty/auto/control-char values).--command, configure-tests reports what detection actually found (no suite, two candidates, or already configured) instead of a false "nothing to write".--command(migrate: commitfinalize.test_command) instead of a hand edit; docs updated.Review (deep tier)
--commandsplice corrupts folded/literal blocktest_commandor inline{...}build:/finalize:testsupport.TempDir): the spliced file is re-parsed and the write refused, file untouched, unless it round-trips exactlyoff(default islocal)The fixes were first reverted after a fix-pass red run (bare
t.TempDir()rejected by repoguard; an unrelatedinternal/processtiming failure), then re-applied on the human-authorized resume. The full suite is green at the head below.Results: docs/results/2026-10-05-repository-init-writes-gate-off-and-configure-tests-then-ref-results.md
command: go run ./cmd/docket development test
result: green
head_sha: 0b2326d
ran_at: 2026-10-05T14:08:02Z