Fix workspace peer dependencies in published packages - #7
Merged
Merged
Conversation
danlapid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing workspace package directories with npm leaves
workspace:*in their peer dependencies. npm consumers then fail withEUNSUPPORTEDPROTOCOL, even though the packages have already been released.Pack each package with pnpm first, then pass the generated tarball to npm for OIDC trusted publishing. pnpm replaces workspace protocols with the appropriate versions; npm continues to handle authentication and provenance. Temporary archives are removed after publishing.
Validation: inspected the packed
durable-object-fsmanifest and verified that itsworker-fs-mountpeer is a normal version. The existing integration suite, build, type checking, and Biome checks pass. Includes patch changesets for packages affected by the published metadata.