test(server): widen logger.separation file-content gate 5s → 30s for cloud shard contention - #662
Merged
Merged
Conversation
… cloud shard contention The gate only bounds how long to wait for the probe's debug-log line to APPEAR; no assertion depends on startup speed. Under full-suite shard contention on a shared Cloud Run vCPU a cold tsx start exceeded the old 5s windows (non-win32) default — observed failing the 2026-08-18 freshell-vitest-l68jz execution while the same shard passed when the file ran alone and locally. Unify with the existing 30s win32 value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
logger.separationintegration test bounded the wait for the probe's debug-log line to 5s on non-Windows. Every assertion in the file is about which log filename a launch mode chooses — none are about startup speed. Under full-suite shard contention on a shared Cloud Run vCPU, a coldtsxstart exceeded 5s and failed the run (execution freshell-vitest-l68jz, 2026-08-18), while the same file passed alone in cloud (15s, 4/4 shards) and locally (3s).Fix
Unify the file-content gate at the existing Windows value (30s) with a comment recording why. Passing runs are unaffected — the wait loop returns the moment the pattern appears; the constant only gates failures.
Test plan
npm run test:vitest -- run test/integration/server/logger.separation.test.ts --config config/vitest/vitest.server.config.ts.npm run test:cloudat the post-merge HEAD (the whole point of this repair chain).