perf(shared-fs): remove unused recursive history depths - #342
Draft
peerbit-org wants to merge 1 commit into
Draft
peerbit-org wants to merge 1 commit into
peerbit-org wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small master-based cleanup, independent of held #331/upstream upgrade: remove unused recursive history-depth computation and private depth maps. Keep head filtering and all stored-causalDepth/non-delete/ID winner rules unchanged. No new cache, API/schema change, dependency change or replication-policy change.
The new pre-change regression exposed
Maximum call stack size exceededfor a 20,000-event reverse-ordered naming history. Removing the unused recursion fixes it; both naming and content deep-chain cases now pass.Verification
HOLD — strict full run failed
The full library suite used the opt-in runner/reporter from #340 via explicit config path, without changing its budgets. It reported542 eventual passes /10 skipped, but correctly exited1 on one actual persistent-multi-writer retry (
missingInstrumentation:0). Do not treat that as a clean run or merge this draft.First failure:
expected undefined to be definedfrompersistedReceiptPeerSession(remoteHash)at persistent-multi-writer.test.ts:100, reached from line400's Promise.all index1 after restart/convergence and before prepareForDisposal. The remote identity was not captured. This resembles the prior older-cohort readiness failure category; it is not a new proof of latest-cohort failure, data loss, or a proven identical root cause.All23 new tests and existing shared-fs31 /GC14 /compaction6 /durable-disposal22 cases passed without retries. No local or CI rerun, timeout inflation, assertion weakening or check bypass. Ordinary CI on this branch does not yet include #340's strict gate; a green result there does not clear this recorded hold.
Local raw evidence:
/private/tmp/peerbit-performance-20260905/unused-depth-library-strict.log(first failure line230),unused-depth-baseline-regressions.log,unused-depth-after-regressions.log,unused-depth-baseline.raw.log,unused-depth-after.raw.log.All git/GitHub actions as verified peerbit-org. No upstream writes or release.