Fix publish event content type handling - #1797
Conversation
Signed-off-by: Dang Zitou <dengzitao888@163.com>
Signed-off-by: Dang Zitou <dengzitao888@163.com>
|
The current head re-triggers CI after the previous run was affected by an external example-job conflict. GitHub has marked the fork-originated workflows as awaiting maintainer approval. Could a maintainer please approve the pending Build, Auto Validate Examples, Javadocs, and FOSSA workflows? The latest commit is DCO-signed and only exists to obtain a clean validation run. |
Signed-off-by: Dang Zitou <dengzitao888@163.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1797 +/- ##
============================================
+ Coverage 77.10% 77.17% +0.06%
- Complexity 2317 2331 +14
============================================
Files 245 245
Lines 7186 7199 +13
Branches 750 758 +8
============================================
+ Hits 5541 5556 +15
Misses 1284 1284
+ Partials 361 359 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
CI follow-up: I added two focused regression cases for the previously uncovered branches: implicit Boolean payloads and explicit Validation:
The remaining |
Fixes #779
Summary
text/plainfor String, Number, and Boolean payloads when no content type is suppliedapplication/octet-streamfor byte arrays and keep their raw bytes on the gRPC pathReproduction
Before the fix, four focused regression tests were run three times. All four failed consistently: an explicit
text/plainString was JSON-quoted, and implicit String, Number, and byte-array payloads were all labeledapplication/json.After the fix, those cases pass, along with coverage for POJO serialization and preservation of a custom
image/pngbyte-array payload.Validation
JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ./mvnw -pl sdk clean testNo screenshot is needed because the regression tests assert the exact content type and wire-level protobuf payload bytes.