Skip to content

Traditional Chinese language update - #612

Open
jimmyorz wants to merge 8 commits into
darrylmorley:mainfrom
jimmyorz:main
Open

jimmyorz wants to merge 8 commits into
darrylmorley:mainfrom
jimmyorz:main

Conversation

@jimmyorz

@jimmyorz jimmyorz commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Localization
    • Revised Traditional Chinese wording for cable diagnostics, connection status, USB labels, Thunderbolt networking, display-bandwidth diagnostics, and Power Delivery event logs.
    • Standardized terminology for connections, connectors, cables, power sources, limiting factors, and reported outcomes.
    • Clarified descriptions of request results, adapter limitations, and accessory plug roles.
    • Improved punctuation, spacing, and formatting consistency across affected messages.

- Refine translations for newly introduced strings.
- Restore Traditional Chinese translations from darrylmorley#605 that were reverted by a later sync.
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 45ffd061-f6d8-4c74-a412-5246cf866fa3

📥 Commits

Reviewing files that changed from the base of the PR and between c22b8d2 and 2b5c5f3.

📒 Files selected for processing (1)
  • Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings
🚧 Files skipped from review as they are similar to previous changes (1)
  • Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The Traditional Chinese localization revises terminology and descriptions for cable diagnostics, connection status, display diagnostics, and PD event logs. It also standardizes punctuation and frequency formatting.

Changes

Traditional Chinese localization

Layer / File(s) Summary
Translation wording revisions
Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings
Reworded cable termination, transfer speed, USB connection, Mac link, Thunderbolt networking, display diagnostics, PD event-log, and plug-type strings. Standardized terminology, full-width parentheses, spacing, and diagnostic descriptions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updates to Traditional Chinese localization strings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jimmyorz

Copy link
Copy Markdown
Contributor Author

Hi @darrylmorley ,I noticed that some of the Traditional Chinese translations merged in #605 appear to have been reverted, possibly because they weren't synced back to the local working copy before the latest language update.

I've restored the affected Traditional Chinese translations in this PR. It looks like the Italian translation has the same issue as well, so just a heads-up for you and @bovirus to keep an eye on this when syncing translations. Thanks!

@jimmyorz
jimmyorz marked this pull request as draft September 17, 2026 17:54
Refine translations for newly introduced strings.
@jimmyorz
jimmyorz marked this pull request as ready for review September 17, 2026 17:55
@jimmyorz
jimmyorz marked this pull request as draft September 18, 2026 10:51
@jimmyorz
jimmyorz marked this pull request as ready for review September 18, 2026 10:56
@jimmyorz
jimmyorz marked this pull request as draft September 21, 2026 17:47
- Refine translations for newly introduced strings.
- Improve translation consistency.
Improve translation consistency.
@jimmyorz
jimmyorz marked this pull request as ready for review September 21, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant