Skip to content

fix(lock): show cancel action in forgot PIN recovery - #1000

Merged
llbartekll merged 1 commit into
developfrom
codex/fix-forgot-pin-cancel
Aug 12, 2026
Merged

fix(lock): show cancel action in forgot PIN recovery#1000
llbartekll merged 1 commit into
developfrom
codex/fix-forgot-pin-cancel

Conversation

@llbartekll

@llbartekll llbartekll commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep the modal Cancel action visible on the recovery phrase screen opened from Forgot PIN
  • return safely to the lock screen without changing the existing PIN

Testing

  • manually verified by requester
  • full build skipped per requester

Summary by CodeRabbit

  • Style
    • Repositioned the PIN recovery modal’s Cancel button from the left side of the navigation bar to the right side.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fd60628a-c9f2-484d-a973-51fc2001ef37

📥 Commits

Reviewing files that changed from the base of the PR and between af5bfea and b43fb6a.

📒 Files selected for processing (1)
  • DashWallet/Sources/UI/LockScreen/DWLockScreenViewController.m

📝 Walkthrough

Walkthrough

The PIN recovery modal now places its cancel button on the right side of the navigation bar.

Changes

PIN Recovery UI

Layer / File(s) Summary
Cancel button placement
DashWallet/Sources/UI/LockScreen/DWLockScreenViewController.m
The recovery controller places the cancel button in the right navigation-item slot.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: quantumexplorer

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: showing the Cancel action during Forgot PIN recovery.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-forgot-pin-cancel

Comment @coderabbitai help to get the list of available commands.

@llbartekll
llbartekll merged commit c280876 into develop Aug 12, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant