Skip to content

feat: support Platform devnet quorum parameters - #12

Merged
ktechmidas merged 1 commit into
dashpay:masterfrom
infraclaw-dash:ops/moutai-devnet-support-20260827
Aug 27, 2026
Merged

feat: support Platform devnet quorum parameters#12
ktechmidas merged 1 commit into
dashpay:masterfrom
infraclaw-dash:ops/moutai-devnet-support-20260827

Conversation

@infraclaw-dash

@infraclaw-dash infraclaw-dash commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add devnet as a generic supported network class
  • select the standard Platform devnet quorum (llmq_devnet_platform, type 107)
  • use the standard devnet DAPI port (1443)
  • add focused tests for parsing, TOML deserialization, and the selected parameters

Why

dashpay/quorum-list-server:latest currently accepts only mainnet, testnet, and regtest. A generic devnet configuration is rejected and the process falls back to testnet defaults, so it cannot serve Platform quorum lists for Dash devnets.

The service only needs the network class to choose protocol parameters. Individual deployment names remain outside this enum; every Dash devnet uses the canonical devnet value.

Validation

  • focused Rust tests for config::tests (2 passed, 0 failed)
  • git diff --check
  • prior ARM64 release build validation for the same Platform devnet parameter path

No deployment or end-to-end test was run for the generic naming cleanup.

Companion deployment PR

Release follow-up

The Docker release workflow runs only for v* tags. After merge, a new release tag is required to publish this support in both the versioned multi-architecture image and dashpay/quorum-list-server:latest.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b2ff997-ff16-4b63-967b-29f7f2d39ee2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@infraclaw-dash

Copy link
Copy Markdown
Contributor Author

@shumkov This is the source-side companion to dashpay/dash-network-deploy#747. The patch has focused config tests, passed an ARM64 release build/test, and the canonical devnet-porter path is serving the live Moutai quorum payload. Could you review when convenient? After merge, a new v* release tag is needed for the workflow to publish the multi-architecture image.

@ktechmidas
ktechmidas self-requested a review August 27, 2026 12:32
@infraclaw-dash
infraclaw-dash force-pushed the ops/moutai-devnet-support-20260827 branch from 8e92e24 to 426406e Compare August 27, 2026 12:43
@infraclaw-dash

Copy link
Copy Markdown
Contributor Author

Corrected the network model: this PR now adds only the canonical generic devnet class. All Porter/named-devnet aliases and tests have been removed. Focused config tests pass (2/2); no deployment or E2E rerun was performed for this cleanup.

@ktechmidas ktechmidas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktechmidas
ktechmidas merged commit d40e479 into dashpay:master Aug 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants