feat(cpp): Add cpp driver with rust binding. - #609
Closed
Electronic-Waste wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Electronic-Waste <2690692950@qq.com>
Electronic-Waste
marked this pull request as draft
March 27, 2025 08:23
everpcpc
reviewed
Mar 27, 2025
| let query_str = query.to_str().unwrap(); | ||
| tokio::runtime::Runtime::new() | ||
| .unwrap() | ||
| .block_on(self.connection.exec(query_str, None)) |
Member
There was a problem hiding this comment.
We could make this global runtime
cc https://github.com/databendlabs/bendsql/blob/main/bindings/python/src/utils.rs#L27
Author
There was a problem hiding this comment.
Sure! I'll update it. Thanks for your review!
Member
|
Review result: closing this PR. Reason: This PR has remained a draft since 2025-03-27 and only contains the initial C++ binding skeleton. It was not updated after review, and the current changes are missing main.cpp, tests, error handling, and complete C++ API/build validation, so they are not ready to merge. If a C++ driver is still needed, please redesign and submit a complete new PR based on the current bindings structure. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we scheduled before, we decided to implement an ODBC driver for Databend. Unlike ClickHouse, we prefer to use native client (bendsql) than http client to connect to the database. However, we haven't had C++ driver for databend up to now, which means that we should implement it right now to support ODBC driver.
This PR will implement the cpp driver with rust binding, including:
/cc @flaneur2020 @hantmac @everpcpc @ZhiHanZ