Skip to content

ci: post single "Python Integration Tests" check (unify with go/nodejs)#881

Closed
eric-wang-1990 wants to merge 1 commit into
mainfrom
ci/python-single-check
Closed

ci: post single "Python Integration Tests" check (unify with go/nodejs)#881
eric-wang-1990 wants to merge 1 commit into
mainfrom
ci/python-single-check

Conversation

@eric-wang-1990

Copy link
Copy Markdown
Contributor

Summary

Python was the last multi-backend driver posting per-mode checks (Python Proxy Tests / thrift + / kernel). The paired driver-test receiver (databricks-python-integration-tests.yml) now fans out both backends internally and reports one aggregated Python Integration Tests check, matching go/nodejs.

This sender change:

  • Collapses the five MODES=['thrift','kernel'] two-check loops (skip / label auto-pass / dispatch-fail / merge-queue auto-pass / merge-queue-fail) into a single Python Integration Tests check.
  • Adds proxy_mode: replay to both dispatch payloads (parity with the other senders — the PR gate is replay-only).
  • Fixes the PR-comment link to the new receiver workflow.
  • The dispatch was already a single python-pr-test (no per-mode fan-out on the sender side).

Ordering / follow-up

  • Land the driver-test receiver PR first (it creates the Python Integration Tests check name).
  • Branch protection (manual, after both land): swap required checks — remove Python Proxy Tests / thrift + / kernel, add Python Integration Tests. Doing it out of order would deadlock PRs, so it's sequenced last.

Test Plan

  • YAML parses
  • All 5 check-creations post Python Integration Tests; both dispatches carry proxy_mode: replay
  • No residual MODES loop or per-mode check name (only header/swap-note comments reference the retired names intentionally)

This pull request and its description were written by Isaac.

Python was the last multi-backend driver posting per-mode checks
(`Python Proxy Tests / thrift` + `/ kernel`). The new standalone receiver
in databricks-driver-test (databricks-python-integration-tests.yml) fans
out both backends internally and reports ONE aggregated check, matching
go/nodejs.

Collapse the five `MODES=['thrift','kernel']` two-check loops (skip / label
auto-pass / dispatch-fail / merge-queue auto-pass / merge-queue-fail) into a
single `Python Integration Tests` check, add `proxy_mode: replay` to both
dispatch payloads for parity with the other senders, and fix the PR-comment
link to the new receiver workflow. The dispatch itself was already a single
`python-pr-test` (no per-mode fan-out on the sender).

Follow-up (branch protection, done separately): swap the required-checks
list — remove `Python Proxy Tests / thrift` and `/ kernel`, add
`Python Integration Tests`. Sequenced after this + the receiver land to
avoid a deadlock.

Co-authored-by: Isaac
Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
Copilot AI review requested due to automatic review settings July 24, 2026 07:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@eric-wang-1990

Copy link
Copy Markdown
Contributor Author

Folded into #879 (same file, trigger-integration-tests.yml). The single-check unification now rides on #879's branch alongside the coverage-fanout sender; closing this standalone PR.

@eric-wang-1990
eric-wang-1990 deleted the ci/python-single-check branch July 24, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants