fix: declare runtime-only @deepseek-ai deps so electron-builder bundles them - #10
Open
lmcsh9527 wants to merge 1 commit into
Open
fix: declare runtime-only @deepseek-ai deps so electron-builder bundles them#10lmcsh9527 wants to merge 1 commit into
lmcsh9527 wants to merge 1 commit into
Conversation
…es them The packaged app fails at startup with ERR_MODULE_NOT_FOUND for 19 @deepseek-ai packages (dsh-shell, dsh-subprocess, dsh-sandbox, ...). These are loaded dynamically by the DSH web profile at runtime, so npm does not install them as transitive deps of @deepseek-ai/dsh and electron-builder prunes them from the app bundle. Declaring them as direct dependencies makes electron-builder include them (files: node_modules/**/*), fixing the crash for all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The packaged app crashes at startup on all platforms:
The app bundle is missing 19
@deepseek-aipackages (dsh-shell, dsh-subprocess, dsh-sandbox, dsh-fs, ...). See issue #9.Root cause
These packages are loaded dynamically at runtime by the DSH web profile — they are not declared as dependencies of
@deepseek-ai/dsh, so npm does not install them and electron-builder prunes them from the bundle (thefileslist includesnode_modules/**/*, but they were never there).Fix
Declare the 19 runtime packages as direct dependencies (pinned to the same rc.6 line as
@deepseek-ai/dsh), so electron-builder includes them.Verification
Copying these packages from a full dsh install into the app bundle fixes the crash — the Harness then boots and serves HTTP 200 (verified on macOS x64). This PR makes that copy unnecessary.
Notes
0.1.0-rc.6,@deepseek-ai/cordis-plugin-groupat1.0.1.