Repository navigation
JCU: expose SSR cache hits, misses and hit rate - #1681
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSR stats endpoint now exposes per-worker, per-cache
hits,misses, andhitRate.Only three files change:
server.ts: keep two counters per cache, increment them in the existing hit/miss branches, and pass them to the stats snapshot. No extra request-path lookups, branches, or allocations.src/backend/ssr-cache-stats.ts: type and expose the counters; calculatehitRateonly when stats are polled. Stale pages served count as hits; the rate isnullbefore any lookups. Counters reset on worker restart.scripts/test-ssr-cache-stats.js: adjust the existing snapshot tests for the added fields and rate. No new test cases.Validation:
npm run test:ssr-cache-statspassed (7 tests), focused TypeScript check passed, andgit diff --checkpassed.