Repository navigation
Add four-phrase authoritative world - #17
Merged
Merged
Conversation
datashaman
marked this pull request as ready for review
August 10, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12.
What changed
world.snapshoteventspushtrigger tomain, preventing PR branch commits from running the same macOS build once forpushand again forpull_requestWhy
Milestone 3 needs one source of truth for both the musical composition and the visible phrase world before native motion and direct manipulation are introduced. The UI previously displayed a hard-coded four-object preview while the engine scheduled only bass.
CI also subscribed unconditionally to both
pushandpull_request. Every commit on an open PR branch therefore launched two identical workflows for the same SHA. PR updates now use thepull_requestrun, while merges and direct updates tomainretain thepushrun.Impact
The packaged app now visibly and audibly demonstrates the initial four-role composition. React no longer invents phrase state, and the next spatial-world slice can add native motion without changing the snapshot ownership boundary.
Each PR update now consumes one macOS Actions runner instead of two, without dropping post-merge CI on
main.Validation
./scripts/verify.shactionlint .github/workflows/ci.ymlc4b72866produced exactly one successful Actions run, triggered bypull_requestgit diff --check