Skip to content

Expand deterministic collision composition - #25

Merged
datashaman merged 1 commit into
mainfrom
agent/issue-22-composition-collisions
Aug 15, 2026
Merged

datashaman merged 1 commit into
mainfrom
agent/issue-22-composition-collisions

Conversation

@datashaman

Copy link
Copy Markdown
Owner

Closes #22.

What changed

  • author three compatible A, B, and C variants for drums, bass, chords, and melody
  • add explicit deterministic targets for all six unordered phrase collision pairs
  • cycle mapped targets through A → B → C → A at the next eligible unscheduled bar
  • sort simultaneous contacts by stable pair IDs and accept at most one pending transition per target phrase
  • publish all pair targets, contact states, and cooldowns through native and typed UI snapshots
  • render every phrase's current/pending variant and all pair diagnostics
  • document the collision map and conflict policy
  • constrain the fullscreen grid to the viewport and scroll diagnostics independently

Why

The previous tracer bullet only mapped drums + bass to bass variant B. The visual world therefore had five collision pairs with no musical effect and only one alternate phrase. This completes the four-role collision composition while keeping outcomes predictable, quantized, and independent of physics iteration order.

The expanded six-pair diagnostics exposed an existing layout constraint: .shell used min-height: 100vh, and the sidebar's intrinsic height enlarged the grid beyond the viewport while body hid overflow. The shell now has a fixed viewport height, grid children may shrink, and the diagnostics pane scrolls independently.

Validation

  • ./scripts/verify.sh
  • Debug CTest: native and deterministic stress tests passed
  • Release CTest: native and deterministic stress tests passed
  • UI: 14 tests passed
  • repeated ten-minute deterministic stress simulation: 1,185 contacts, 743 applied transitions, 16,182 paired MIDI messages, zero late MIDI, zero timestamp error, zero phase drift
  • headless Chromium fullscreen geometry: field bottom moved from 1,101 px in an 895 px viewport to 867 px with a 28 px bottom margin
  • manual fullscreen review: approved

@datashaman
datashaman marked this pull request as ready for review August 15, 2026 06:40
@datashaman
datashaman merged commit 08536b8 into main Aug 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand deterministic collision variants across the composition

1 participant