Repository navigation
Expand deterministic collision composition - #25
Merged
Merged
Conversation
datashaman
marked this pull request as ready for review
August 15, 2026 06:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
What changed
A,B, andCvariants for drums, bass, chords, and melodyA → B → C → Aat the next eligible unscheduled barWhy
The previous tracer bullet only mapped drums + bass to bass variant B. The visual world therefore had five collision pairs with no musical effect and only one alternate phrase. This completes the four-role collision composition while keeping outcomes predictable, quantized, and independent of physics iteration order.
The expanded six-pair diagnostics exposed an existing layout constraint:
.shellusedmin-height: 100vh, and the sidebar's intrinsic height enlarged the grid beyond the viewport whilebodyhid overflow. The shell now has a fixed viewport height, grid children may shrink, and the diagnostics pane scrolls independently.Validation
./scripts/verify.sh