Repository navigation
Make two proximity rhythm mappings auditionable - #32
Merged
Merged
Conversation
datashaman
marked this pull request as ready for review
August 15, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
What changed
Why
Proximity was visible in Drift but did not yet affect the sound. This PR makes two intentionally constrained rhythm treatments directly comparable during uninterrupted playback without prematurely selecting a production mapping.
User impact
Moving phrases together now produces an audible, bar-quantized rhythmic relationship. The Proximity selector switches between the two candidates at the next bar, while Freeze Motion and dragging continue to observe proximity without stopping MIDI playback.
Validation
npm --prefix ui test -- --run— 14 tests passednpm --prefix ui run buildcmake --preset debug && cmake --build --preset debug && ctest --preset debug --output-on-failurecmake --preset release && cmake --build --preset release && ctest --preset release --output-on-failuregit diff --check