Skip to content

Keep both proximity modes and refresh packaged UI - #33

Draft
datashaman wants to merge 1 commit into
mainfrom
agent/keep-proximity-modes
Draft

datashaman wants to merge 1 commit into
mainfrom
agent/keep-proximity-modes

Conversation

@datashaman

Copy link
Copy Markdown
Owner

What changed

  • keep both validated proximity mappings as permanent musician-selected modes
  • rename the user-facing choices to Lock Rhythm and Accent Together
  • document the live-MIDI decision from Choose the proximity rhythm mapping through live MIDI #31 and remove temporary-audition framing
  • make generated UI outputs link dependencies of Drift so UI-only changes rerun the app bundle copy

Why

Live audition through IAC Driver Bus 1, Ableton Live, and multiple AU instruments found that neither mapping supersedes the other: Lock Rhythm is useful for temporal alignment, while Accent Together preserves authored timing and emphasizes coordination.

The packaging change fixes a separate issue discovered during that validation. The UI build had regenerated current assets, but its copy lived only in the native target's post-link step. When the executable itself was already current, an incremental UI-only build skipped the copy and launched stale controls.

User impact

Proximity remains an explicit musical choice rather than an automatic behavior. The clearer labels describe the audible result, and packaged Debug/Release apps reliably contain the latest UI after incremental builds.

Validation

  • npm --prefix ui test -- --run — 14 tests passed
  • npm --prefix ui run build
  • cmake --preset debug && cmake --build --preset debug && ctest --preset debug --output-on-failure
  • cmake --preset release && cmake --build --preset release && ctest --preset release --output-on-failure
  • verified Debug and Release packaged app.js/app.css hashes exactly match ui/dist
  • verified packaged Debug JavaScript contains both permanent labels
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant