Repository navigation
Keep both proximity modes and refresh packaged UI - #33
Draft
datashaman wants to merge 1 commit into
Draft
datashaman wants to merge 1 commit into
datashaman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Live audition through IAC Driver Bus 1, Ableton Live, and multiple AU instruments found that neither mapping supersedes the other: Lock Rhythm is useful for temporal alignment, while Accent Together preserves authored timing and emphasizes coordination.
The packaging change fixes a separate issue discovered during that validation. The UI build had regenerated current assets, but its copy lived only in the native target's post-link step. When the executable itself was already current, an incremental UI-only build skipped the copy and launched stale controls.
User impact
Proximity remains an explicit musical choice rather than an automatic behavior. The clearer labels describe the audible result, and packaged Debug/Release apps reliably contain the latest UI after incremental builds.
Validation
npm --prefix ui test -- --run— 14 tests passednpm --prefix ui run buildcmake --preset debug && cmake --build --preset debug && ctest --preset debug --output-on-failurecmake --preset release && cmake --build --preset release && ctest --preset release --output-on-failureapp.js/app.csshashes exactly matchui/distgit diff --check