Skip to content

Fix #351 #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NSExceptional wants to merge 1 commit into from
+6 −0
Open

Fix #351 #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions TrustKit/Reporting/TSKBackgroundReporter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@ - (void) pinValidationFailedForHostname:(nonnull NSString *)serverHostname
[NSException raise:@"TSKBackgroundReporter runtime error"
format:@"Report cannot be saved to file: %@", [error description]];
#endif
// In production, if the report could not be written, bail out here. Otherwise we would go on to
// hand a non-existent file to -uploadTaskWithRequest:fromFile:, which throws an uncaught
// NSInvalidArgumentException ("Cannot read file at ...") and crashes the app.
// https://github.com/datatheorem/TrustKit/issues/351
TSKLog(@"Report for %@ could not be saved to file; skipping upload: %@", serverHostname, [error description]);
return;
}
TSKLog(@"Report for %@ created at: %@", serverHostname, [tmpFileURL path]);

Expand Down