BDSP AutoStory v4: game actions, battles and their detectors by dayfine · Pull Request #148 · dayfine/Arduino-Source

dayfine · 2026-11-01T22:19:13Z

Depends on #152 (base bdsp/detectors-v4); the diff shows only this PR's change.

The game actions the BDSP story steps use, as their own files with the detectors they read, kept to what the story needs.

Saving, the X menu (found by its bottom bar, past NEW tags), the Bag and Potions, the Pokemon Center (heals from inside the door; talk_to_nurse()), trainer and wild battles (running uses a menu check that holds for any party), the Options check, and the system keyboard.
The new game's intro: refuses to start from HOME, checks the game is BDSP, waits out the black boot, confirms the rival's name, reads arrowless dialogue, and ends only on the X menu; the player is "Kosmos" by default for lab runs.
About 1,200 lines are adapted from [WIP] BDSP Autostory PokemonAutomation/Arduino-Source#1717 by Developer-Butters and credited in each file.

Testing

Suites: AutoStory Actions (the intro's decisions) and the screenshot checks, which need PokemonBDSP: DialogDetector and MenuDetector test screens CommandLineTests#1.
Console: the intro fixes were checked on console B (runs r1–r6); the Center and save fixes come from runs r50 and r52.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

What the BDSP story table's steps do in the game, without the story itself: saving and the X menu (Actions), the Bag and Potions (Bag), the Pokemon Center by its lit doorway (Center), trainer battles with the best move (Battle), the Starly battle, catching and running from wild battles (WildBattle), the Options the story needs (Settings), and a new game's intro to the bedroom (NewGame), with the detectors they read: the battle menu and move cursor, the X menu's cursor, the name list and the Switch's keyboard. Tests: the intro's decisions, and the lit doorway, Pokemon Center, save card and School lamp screenshots. Adapted in part from PokemonAutomation#1717 by Developer-Butters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…nners Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…enu and X menu readers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…on#1717 in the X menu reader Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

The repo's control-flow formatting throughout; long functions split into helpers that run the same statements in the same order; the move reading moved to BattleMoves. Battle drops the parameters and branches no caller used (a confirmed default target, move lists, no post-battle cleanup): every battle takes the best move each turn, and fight_story_battle() takes BattleFormat instead of a bool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

… BDSP, read arrowless dialogue r1 (2026-11-01) started with no game running: closing it failed, HOME was pressed again, its cursor moved to the first tile, and FireRed was launched and played for 30 s. The intro now refuses to start with HOME in front, and before a screen only BDSP shows (its dialogue box, the rival's name list, its menu) presses A on unknown screens at most 20 times, then fails as another game. r2 stopped on Rowan's last line: a dialogue box without the "more" arrow, which ShortDialogDetector needs, read as "other", and the background's sparkles read as X changing the screen. The intro now reads such a box as dialogue, and the probe compares only the box's area. Tests: the intro's decisions with the new gate; the intro screens from CommandLineTests (PokemonBDSP/AutoStory/IntroScreens), skipped without them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…anged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…t line, which a long line reaches Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

… then X; only the menu ends the intro Screens the classifier misses no longer stop the intro: once the rival is named, each unknown screen takes B (up to INTRO_B_BEFORE_X), then X checks for the menu, up to INTRO_X_WITHOUT_MENU times. Dialogue takes B too. The before/after comparison of the X probe is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…nctions and story_language() Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…or the wrong-game guard r3 spent the guard's 20 presses on BDSP's black boot (about 25 s after the restart) and stopped. Now the intro waits for a screen that is not black before it starts (up to INTRO_BOOT_LIMIT), black screens are their own class that takes no press, and the guard counts INTRO_TIME_BEFORE_BDSP from the first screen that is not black instead of presses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

r4 picked Barry, then B answered "Barry, is it?"'s Yes/No as No and the list came back until the state machine's visit limit. Picking a preset now leaves the name pending: dialog and unknown screens take A (Yes) until INTRO_SCREENS_AFTER_RIVAL_PICK of them pass without the list, and the list coming back is picked from again (up to 6 visits). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…X opening something from a still bedroom r5 reached the bedroom, but a new game's X menu (BAG and OPTIONS with a NEW tag) is not the full menu MenuDetector wants, and the intro pressed X twelve times. XMenuDetector also takes the blue bar along the bottom, there from the first menu on, for the intro and the Options steps. And when X opens something no detector knows from a screen that held still, and B puts it back, the player is in control too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…to bdsp/actions-v4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…elow a long first line; their screenshots in CommandLineTests The intro's misses were the detectors' (r2, r5), so they are fixed there: MenuDetector also looks at its white columns from below the "NEW" tags (a new game's OPTIONS has one beside the third column), and ShortDialogDetector takes the box's right end below the first line when a long first line covers it. The AutoStory-only XMenuDetector and the intro's own dialogue check go; the screenshots are registered per file from CommandLineTests' PokemonBDSP/MenuDetector and DialogDetector, and the AutoStory folder readers for them are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

The MenuDetector and ShortDialogDetector changes now come from their own PR; this PR keeps only the AutoStory side. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

… NEW tags A new game's main menu has a "NEW" tag above OPTIONS that breaks the top of the third white column. MenuDetector already handles that with skip_new_banner = true, so every menu check in the intro and the settings checkpoint passes it, instead of MenuDetector itself changing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

MenuDetector keeps its old check (review on #152); the callers here pass skip_new_banner instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…ions-v4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…r any party Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

heal_inside_pokemon_center() is heal_at_pokemon_center() after the door, for a caller that walks in from a known tile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

For a caller that leaves the Center its own way: the walk out's indoor check read "not a room" a step from the counter (r50), so 00.04b ended inside. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

The Bag check used overworld_to_menu(), whose menu read misses the NEW tags (r52: the menu was open, "Menu not detected after 10 seconds"). One opener, with the tags allowed, for both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…tions-v4

…ions-v4

dayfine and others added 4 commits November 1, 2026 13:59

BDSP AutoStory actions: drop the unused Bag icon box and the moved ba…

cf389f3

…nners Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

BDSP AutoStory actions: credit PokemonAutomation#1717 in the battle m…

18d71e0

…enu and X menu readers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

BDSP AutoStory actions: CRLF line endings, and credit PokemonAutomati…

842a043

…on#1717 in the X menu reader Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine mentioned this pull request Nov 1, 2026

BDSP AutoStory v4: new game to Floaroma as one story table on the shared steps #128

Draft

dayfine and others added 8 commits November 1, 2026 14:46

System keyboard: the cursor's walk to a key as its own function, unch…

6158441

…anged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

BDSP AutoStory new game: the arrowless box's right end below the firs…

682fdad

…t line, which a long line reaches Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge remote-tracking branch 'origin/bdsp/walk-v4' into bdsp/actions-v4

aa399da

BDSP AutoStory actions: walk-v4's stick positions, StoryWorld free fu…

c60b30a

…nctions and story_language() Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

This was referenced Nov 1, 2026

BDSP AutoStory: segments 00 and 01 on the shared story steps, simulated end to end #124

Closed

BDSP AutoStory MVP: new game to Floaroma on #1717 and the shared core #68

Closed

dayfine added autostory AutoStory programs detector Screen detectors and readers game:bdsp Brilliant Diamond/Shining Pearl labels Nov 1, 2026

dayfine and others added 5 commits November 1, 2026 15:18

Merge remote-tracking branch 'origin/bdsp/walk-v4' into bdsp/actions-v4

8b99d91

Merge bdsp/walk-v4 (ba95847: PokemonAutomation#1717 credits, CRLF) in…

15e6d23

…to bdsp/actions-v4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine changed the base branch from bdsp/walk-v4 to bdsp/detectors-v4 November 2, 2026 00:08

dayfine and others added 3 commits November 1, 2026 16:26

Merge bdsp/detectors-v4 into bdsp/actions-v4

9e603d7

MenuDetector keeps its old check (review on #152); the callers here pass skip_new_banner instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge remote-tracking branch 'origin/bdsp/detectors-v4' into bdsp/act…

9f5d260

…ions-v4

dayfine mentioned this pull request Nov 2, 2026

NintendoSwitch: system keyboard detector and mixed-case typing on FastCodeEntry #157

Open

BDSP AutoStory: the save prompt reads the menu past its NEW tags

615805b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine and others added 26 commits November 1, 2026 19:39

Merge bdsp/walk-v4 forward

249a414

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/nav-v4 forward

73cf5d8

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/nav-v4 forward

091ff27

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

ce2332c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

BDSP AutoStory: run from wild battles on the menu check that holds fo…

5c8cde5

…r any party Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

50d4f7d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

284a95e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

65c6ef3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

f7de4a1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/detectors-v4 into bdsp/actions-v4

aae2a9f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/detectors-v4 into bdsp/actions-v4

34a45c0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/detectors-v4 into bdsp/actions-v4

81e853a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/detectors-v4 into bdsp/actions-v4

e6f8961

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/detectors-v4 into bdsp/actions-v4

48839f6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/detectors-v4 into bdsp/actions-v4

13b673f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/detectors-v4 into bdsp/actions-v4

ba8f27c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/detectors-v4 into bdsp/actions-v4

9796a6d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/detectors-v4 into bdsp/actions-v4

df4f08b

Merge origin/bdsp/detectors-v4 into bdsp/actions-v4

d439809

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/detectors-v4 into bdsp/actions-v4

f912520

Merge bdsp/maps-v4 (coord events) into bdsp/actions-v4

9799ddd

Merge bdsp/detectors-v4 into bdsp/actions-v4

1dd00bc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/detectors-v4 (139d483: verify mode from #122) into bdsp/ac…

76e3649

…tions-v4

dayfine added this pull request to stack #230 November 5, 2026 18:39

dayfine added 3 commits November 5, 2026 12:19

Merge commit 'f5a3c42abf063fcc366f024a9a7986a9c97dd836' into HEAD

101c5b8

Merge remote-tracking branch 'origin/bdsp/detectors-v4' into bdsp/act…

073c4a1

…ions-v4

BDSP AutoStory actions: align with PR #231 lint conventions

53f077a

Navigation Menu

Repository navigation

BDSP AutoStory v4: game actions, battles and their detectors - #148

BDSP AutoStory v4: game actions, battles and their detectors#148
dayfine wants to merge 55 commits into
bdsp/detectors-v4from
bdsp/actions-v4

dayfine commented Nov 1, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

dayfine commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dayfine commented Nov 1, 2026 •

edited

Loading