Repository navigation
Conversation
The tap counters read any screen change as our own step, so cloud shadows (r83, r84), TVs and conveyors counted as tiles walked. Outside, the camera follows the player: walk_view_shift() finds the scroll that lines up two frames around the player, and tap_moved() counts a tap only if a scroll lines up at least twice as well as none. Inside, the camera can stay put while the player crosses a room, so the old screen-change line still decides there. WalkUntil's tap walks and dpad_tiles() use it. Measured offline on r83/r84's Floaroma video: standing frames with screen changes up to 57 never read as scrolled; walking read a scroll 2 to 6 times better than none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Walk_Tests.cpp: keep both Test_ViewShift and Test_PokemonCenterOnScreen, their registrations, and both new includes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Do we really need this? seems complicated |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #128 (base
bdsp/autostory-v4); the diff shows only this PR's change. Not for merge into the chain until a console run checks it.Count a D-pad tap as a step only when the view scrolled, so moving scenery stops reading as our own movement.
WalkUntil's tap walks, which the planned routes use, anddpad_tiles()) counted any screen change over a line as a tile walked. Cloud shadows (r83, r84), TVs and the mine's conveyors passed it.walk_view_shift()finds the scroll (±12 px on a 192x108 copy, player's box left out) that best lines up the frames before and after a tap. A step outside scrolls everything one way; scenery changes part of the view with no common scroll.tap_moved(): outside, a tap moved if a scroll lines up at least twice as well as none. Inside, the camera can stay put while the player crosses a room, so the old screen-change line still decides there.settle()keeps whole-screen change on purpose: a walking NPC with a still camera has to count as "not settled yet".Testing
indoors()?).🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E