[dayfine]

Base: main; independent of #183 and AutoStory. The diff shows only this change.

Moves Gift RNG's reset, calibrate and attempt loop out of GiftRng::program into a GiftRngAttempts class, so AutoStory can later run Gift RNG for the Magikarp salesman inside its own program, as #183 did for Starter RNG.

• GiftRngAttempts::run() returns a GiftRngResult (outcome + target Pokemon). Settings, displays, notifications and stats are passed in as GiftRngTarget/Settings/Displays/Notifications/Stats, shaped like FRLG: make Starter RNG's attempts and SID Helper's steps callable #183's Starter structs, with the same on_reset, identify_shiny and max_resets hooks (plus max_rare_candies, read per attempt as before).
• GiftRng::program is now a thin wrapper. Presses, timings, logs, stats names and notifications are unchanged; "5 failed searches" still throws from the program, as FRLG: make Starter RNG's attempts and SID Helper's steps callable #183 does.
• New: identify_shiny (off in Gift RNG) reads a shiny gift's summary and tells whether it hit the target; gift_shiny_outcome() is that check. Names are Gift-specific so they don't clash with FRLG: make Starter RNG's attempts and SID Helper's steps callable #183's identify_shiny when both land.
• Changed: the per-target base stats/gender/level switch is now gift_rng_species(), one return per case, to fit the 50-line function limit; the values are the same and the tests pin each one.
• Moved: the loop body, split into finished, reset_game, check_shiny_gift and run_attempt. Locals became members (m_calibrations, m_target.seed, m_settings.language, ...), so most of it is moved with renames; about 75 of the 253 removed lines show as moved. Compare with git diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change main...frlg/gift-rng-callable-steps.

Testing

• New PokemonFRLG::GiftRngAttempts suite: species values per target, and shiny outcome on/off target.
• Syntax-checked the changed .cpp files with clang and -Wmissing-designated-field-initializers; code health: 0 failures. Mac, Windows Clang and Ubuntu CI dispatched on the branch.
• Not run on the Switch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E