Repository navigation
FRLG: use shared wall recovery without changing navigation behavior - #228
Merged
Merged
Conversation
…overy-adapter # Conflicts: # SerialPrograms/Source/Pokemon/Navigation/Pokemon_WallRecovery_Tests.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
frlg/stage7-celadon(#224), now updated with merged nav-core #227. This diff contains onlyPokemonFRLG_OverworldReanchor.cpp.Delegate FRLG's wall-convergence search to the shared navigation API through static ReanchorPolicy operations and explicit world/surfing context. Existing movement rules, trainer-world alternatives, shortfall policy and route-back validation are preserved.
How to review
Read ReanchorContext/ReanchorPolicy and the call in find_player. The removed search is implemented in merged #227. Use
git diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change frlg/stage7-celadon...frlg/shared-recovery-adapter.Validation
58 focused native cases pass. Current
01cd46204has the identical source tree as testeded38fe72f; its additional merge only connects the refreshed parent ancestry. Canonical lint passes. Full CI is being dispatched and left running. No map, terrain, console or save changes.Evidence and ownership record.