Repository navigation
BDSP: consume pinned Simulation map resources and pickup identities - #249
Merged
Merged
Conversation
…ce-adoption # Conflicts: # SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp
Keep bdsp_map_json as the native API, using validated Packages resources instead of source JSON. Retire duplicate authoring and forward the decomp CLI to Simulation. Pin the enriched candidate from Simulation #65, with resource preparation intentionally blocked until that revision is approved on publishing main. Native schema/legacy tests and 150 complete candidate decoder comparisons pass; full app builds follow publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
bdsp/maps-v4(#134). Also merges nav-core #114's existing shared v2 reader as a prerequisite; no new decoder implementation is added here. This is the BDSP resource handoff corresponding to FRLG #238.BDSP's 22 maps now match Simulation's reviewed baseline. Build the existing
bdsp_map_json()API from pinned prepared Packages resources, remove the authored source-map copies, and retire the duplicate builder/Sinnoh parser and their copied Python tests. The decomp CLI forwards to Simulation; native tests remain in Arduino.PokemonSimulation #65 is merged. Both data and validator tools now pin its approved squash
4de7742a764d27293b4525d6ad2a6fc8a95f3e3a; its manifest/license and all 22 map bytes match the reviewed candidate. Normal resource preparation passes. The shared #114 reader restores omitted pickup names fromsource_event, defaults quantity to one and retains explicit overrides. No controller or story-execution behavior changes.Native full build/test CI at
3d3dd565f(currentc5e7823a6differs only in setup documentation): macOS, Windows Clang, Ubuntu GCC (all passed).For a fresh manual setup, clone Packages before preparing its map subdirectory, then supply the pinned tools/cache paths to CMake. Existing builds need explicit resource preparation and those paths too.
How to review
Review by commit: first the dependency merge from #114, then the BDSP resource change. In the latter, read
SerialPrograms/CMakeLists.txt, the resource lock and CI preparation, thendevtools/maps/RESOURCE_MAPS.md. Most deleted lines are the 22 map copies and authoring code already owned by Simulation. The public native JSON API stays the same.Validation: native schema and legacy CTest targets pass; production native decoders compare all 150 complete plain/enriched map records from the exact candidate; nine retained overlay tests pass; the forwarded decomp CLI works against the existing cache; code health passes against
bdsp/maps-v4. Resource prepare accepts the approved publishing pin. Full native application builds/tests pass on macOS, Windows Clang and Ubuntu GCC; this does not claim live-console validation or BDSP verification of Diamond/Platinum item rewards/flags.