Repository navigation
BDSP: test portability fix + #263 (01.03 authored JSON) into the BDSP line - #264
Merged
Merged
Conversation
* Load BDSP mine checkpoint from shared JSON without changing its executor * Pin the BDSP replay schema correction for paired CI * Compare normalized checkpoint semantics instead of optional JSON defaults * Share authored checkpoint envelopes and embedded resource loading * Use shared authored checkpoint loading for BDSP * Make the native mine plan authoritative and address data review * Space BDSP data declarations and test mutation helpers * Resolve simulator staging root across Python versions * Keep existing Git normalization rules for authored story data * Report actual BDSP story data values in test failures
…' into bdsp/test-portability # Conflicts: # SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStory_StoryTable.cpp
…warps #269 moved the route's target to (46, 57); the authored plan follows it in the merge, and its doc now says so too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
changed the title
dayfine
marked this pull request as ready for review
November 9, 2026 04:15
dayfine
merged commit Nov 9, 2026
e686375
into
bdsp/autostory-mine-floaroma-wip
17 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings three changes into the BDSP line: the recovery-test portability fix, #263 (already reviewed and merged into this branch, not yet into the line), and a doc fix.
Why #263 is here: #263 was stacked on this PR, so merging #263 put it in this branch (
bdsp/test-portability). Merging this PR is what lands it inbdsp/autostory-mine-floaroma-wip. Its code is unchanged from the #263 review.std::string_viewby value. Windows Clang rejected an omittedRunState.flagsdesignated initializer, which is now set explicitly to the same empty state. Two test files, no production change.StoryData/bdsp-mine-01.03.plan.jsonthroughPokemonBDSP_AutoStory_StoryData.*instead of a C++ list. Route, poses, save policy and executor are unchanged. Companion: Consume authoritative Arduino story plans by revision PokemonSimulation#75.bdsp-mine-01.03.mdnow saysabove_the_minestops two tiles short of the warps.To see only what is new since #263:
git diff bd5e3592c origin/bdsp/test-portability.Testing
PokemonBDSP::StoryDatasuite passed on macOS with the headless runner and on Mac and Windows CI. The CI replay passed all nine simulator scenarios (run 42540127290).🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss