Repository navigation
Conversation
…ooks, with tests SV's two retry loops become CheckpointRetryHooks implementations around run_checkpoint_with_retries() in Pokemon/AutoStory, so BDSP and FRLG can plug in their own save and reset. Behaviour is unchanged: save on the first attempt only, day skip on retries when asked, the overworld check after the action (not in the tutorial), one report at attempt 10, and the fatal error past attempt 100. Scripted-hook tests cover each of these. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Closing: the AutoStory event model (#78, engine on nav/event-model) does checkpoint retry, resume and recovery as plain data and callables, so a separate hooks-based retry core would compete with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #45. Base:
autostory/r3-shared-stats; the diff shows only this change.SV's two checkpoint retry loops become
SVCheckpointHooksaround a sharedrun_checkpoint_with_retries(), so other games can plug in their own save and reset. Behaviour is kept: save on the first attempt only, day skip before retries when asked, the overworld check after the action (not in the tutorial), one report at attempt 10, and the fatal error past attempt 100. Scripted-hook tests cover each; built with-Werror, code-health check passes, not run on a Switch.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E