Repository navigation
Conversation
…ks in MoveOnlyFunction Each of these owns its task until it runs and never copies it. The detached std::thread backend, which is not built today, needs its wrapper lambda to be mutable to call the task. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
added
game:shared
…tasks-threads Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…tasks-threads Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…tasks-threads Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #87 (base
common/move-only-function-migrate; the diff shows only this change).Thread,FireForgetDispatcherandScheduledTaskRunnernow hold their tasks asMoveOnlyFunction<void()>, as the thread pool does after #87.Thread_StdThreadDetach.tppisn't built today. Its wrapper lambda becomesmutableso it can still call the task if it is turned back on.run_in_parallelkeepsstd::functionbecause it calls the function through a const reference.ThreadPool_Default'snew_thread_callbackstays as it is; it is outside this batch.Testing
MoveOnlyFunction), Windows clang and Ubuntu (std::move_only_function). Each run also runs the command-line unit tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E