Skip to content

Integrations: hold the Discord webhook finish callback in MoveOnlyFunction - #91

Draft
dayfine wants to merge 4 commits into
common/move-only-pabotbase2-handlersfrom
common/move-only-discord-webhook
Draft

dayfine wants to merge 4 commits into
common/move-only-pabotbase2-handlersfrom
common/move-only-discord-webhook

Conversation

@dayfine

@dayfine dayfine commented Oct 31, 2026

Copy link
Copy Markdown
Owner

Depends on #90 (base common/move-only-pabotbase2-handlers; the diff shows only this change).

DiscordWebhookSender::send() now takes its finish callback as MoveOnlyFunction<void()>.

  • The callback is moved into the scheduled send and never copied. The send lambdas are now mutable so they can call it.
  • No caller passes a finish callback today, so the default nullptr covers every call.

Testing

  • Built on fork CI on this branch, the top of the stack: Mac, Windows clang and Ubuntu, plus the command-line unit tests. Not checked against a real webhook.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…ction

The webhook sender moves the callback into its scheduled send and never
copies it. The send lambdas become mutable so they can call it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine dayfine added game:shared Shared or game-neutral code refactor No behavior change labels Nov 1, 2026
dayfine and others added 3 commits November 2, 2026 15:18
…ly-discord-webhook

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ly-discord-webhook

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ly-discord-webhook

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

game:shared Shared or game-neutral code refactor No behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant