Repository navigation
Story wire: read a step's structured args - #86
Merged
Merged
Conversation
Arduino-Source steps now carry their action's arguments as an `args` object (flags, whole numbers, words) next to a plain `variant` name, instead of "mart CeruleanCity_Mart budget=1500" text. The schema and the Python reader accept it with the same value types as the C++ codec, and the shared wire cases cover it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arduino-Source steps are moving their action arguments out of the free-text
variant("mart CeruleanCity_Mart budget=1500 ...") into anargsobject next to a plain variant name (dayfine/Arduino-Source#312, design indocs/design/AutoStory.mdsection 10 there). This addsargstostory-checkpoint.schema.jsonand tocheckpoint_wire.read_step, accepting flags, whole numbers and words only, as the C++ codec does; per-action keys are checked in the game's C++, not here. Four shared wire cases cover it (one accepted, three rejected); an "empty args" case stays C++-only because the native harness dumps an empty object as null.Tested: full unittest discovery on Python 3.8 and 3.12,
json_schema --check-published,contract_format --check, and the nativeStoryDataTestsexecutable from #312 against the updatedwire-conformance.json. The FRLG plan fixtures are unchanged until the FRLG plans are converted.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss