Rename the browser UI from DDS MVP to DDS Web. - #289
Open
tameware wants to merge 2 commits into
Open
Conversation
Drop the temporary MVP label now that the page is a real DDS Web surface, and align files, Bazel targets, WASM exports, and docs with dds_web. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the web UI surface from “DDS MVP” to “DDS Web”, aligning asset filenames, Bazel targets, WASM export names, test harnesses, and documentation/specs with the new dds_web naming.
Changes:
- Renamed web static assets and supporting scripts from
dds_mvp*todds_web*(HTML/CSS/JS, wasm artifacts, update/clean/serve scripts). - Updated Bazel
//web:*targets and test suites to build/testdds_web_wasmand related helpers. - Updated specs/docs references from “web-mvp” to “web” / “DDS Web”, including updated entry points and commands.
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web/verify_wasm_js.py | Updates wording to reflect DDS Web. |
| web/update_wasm.sh | Builds/copies/patches/verifies dds_web_wasm artifacts. |
| web/tests/web_site.py | Stages a DDS Web site directory and patches/embeds wasm artifacts. |
| web/tests/test_web_html.py | Static charset checks now target dds_web.html. |
| web/tests/test_web_e2e.py | E2E tests now load/stage dds_web.html and DDS Web wasm bytes. |
| web/tests/test_wasm_system.py | System test now uses dds_web_wasm_node.mjs and staged DDS Web artifacts. |
| web/tests/test_wasm_scripts.py | Updates script-module loading to patch_web_wasm / DDS Web constants. |
| web/tests/test_dds_web_js.py | Python harness now runs Node tests against dds_web_test.mjs and dds_web.js. |
| web/tests/dds_web_wasm_node.mjs | Node smoke test now calls dds_web_calc_table / dds_web_solve_leads. |
| web/tests/dds_web_test.mjs | Node unit tests now reference dds_web assets and serve instructions. |
| web/serve_web.py | Local COOP/COEP server now serves dds_web.html and imports web_site. |
| web/requirements.in | Comment updated to point to test_web_e2e.py. |
| web/patch_web_wasm.py | Patch script messages/docs updated for dds_web_wasm. |
| web/gen_wasm_bin_js.py | Generates dds_web_wasm_bin.js and ddsWebWasmBytes() with DDS Web constants. |
| web/dds_web.js | Updates embedded instructions and WASM symbol names to dds_web_*. |
| web/dds_web.html | Updates title/asset references and local serve instructions for DDS Web. |
| web/dds_web.css | Adds DDS Web CSS asset (renamed/copied styling). |
| web/dds_web_wasm.cpp | Renames exported entry points to dds_web_calc_table / dds_web_solve_leads and related helpers. |
| web/dds_web_wasm_test.cpp | Updates native unit tests to call the renamed DDS Web WASM bridge functions. |
| web/clean_wasm.sh | Cleans DDS Web wasm artifacts copied into web/. |
| web/BUILD.bazel | Renames wasm binary/test targets, Python targets, and suites to dds_web_*. |
| web/.gitignore | Ignores generated dds_web_wasm.{js,wasm,bin.js} artifacts. |
| specs/web.md | Renames capability to web and updates DDS Web naming/details. |
| specs/wasm-emscripten.md | Updates references from web-mvp to web and patch script rename. |
| specs/system-concurrency.md | Updates COOP/COEP reference to web/serve_web.py and web spec. |
| MODULE.bazel | Updates emsdk bump note to reference //web:dds_web_wasm and patch_web_wasm.py. |
| docs/wasm_build.md | Updates “Web browser” section and test target names for DDS Web. |
Suppressed comments (5)
specs/web.md:30
- The spec says the WASM module exports a single entry
_dds_web_calc_table, but the Bazel linkopts export both_dds_web_calc_tableand_dds_web_solve_leads. This makes the spec inaccurate and could mislead future changes to the web WASM interface.
web/dds_web_wasm.cpp:42 - Brace placement here is inconsistent with the surrounding Allman-style function definitions in this file, and with the repo C++ style guidelines for function definitions. Consider moving the opening brace onto its own line for readability and consistency.
web/tests/test_dds_web_js.py:35 - The unittest class name still references "Mvp" even though this file and the test method now target dds_web. Renaming the class makes the test output match the new terminology.
web/tests/test_web_html.py:13 - The unittest class name still references "Mvp" even though this test is now validating dds_web.html. Renaming the class makes failures easier to interpret.
web/dds_web_wasm.cpp:37 - Brace placement here is inconsistent with the surrounding Allman-style function definitions in this file, and with the repo C++ style guidelines for function definitions. Consider moving the opening brace onto its own line for readability and consistency.
Keep unittest and gtest names aligned with dds_web so failure output matches the new terminology. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 27 changed files in this pull request and generated no new comments.
Suppressed comments (4)
web/dds_web_wasm.cpp:37
- Function definitions use a same-line opening brace here, but this file otherwise uses Allman style for functions (e.g., web_solver_config). Keeping a consistent brace style avoids clang-format/clang-tidy churn and matches the repository C++ style guide.
web/dds_web_wasm.cpp:42 - Same brace-style issue as web_table_context(): opening brace is on the signature line. Please use Allman style for function definitions to match the rest of the file and the repository C++ conventions.
specs/web.md:28 - This spec says the WASM module has "a single exported entry _dds_web_calc_table", but the BUILD linkopts export both calc_table and solve_leads. The invariant should match the actual exported surface so future emsdk/linkopt changes are reviewed correctly.
This issue also appears on line 36 of the same file.
specs/web.md:36
- This bullet describes calling only dds_web_calc_table, but the page also calls dds_web_solve_leads for opening-lead analysis (see dds_web.js and the system smoke test). Updating the spec keeps it aligned with actual behavior.
Collaborator
Author
|
I've opened Issue #290 for Copilot's comments that are orthogonal to this change. |
tameware
marked this pull request as ready for review
August 5, 2026 05:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per a suggestion from @tzimnoch: Drop the MVP label now that the page is a real DDS web surface. Align files, Bazel targets, WASM exports, and docs with dds_web.