Skip to content

ci: gate releases on a publishable-workspace check - #813

Merged
marvin-hansen merged 4 commits into
deepcausality-rs:mainfrom
marvin-hansen:main
Sep 25, 2026
Merged

marvin-hansen merged 4 commits into
deepcausality-rs:mainfrom
marvin-hansen:main

Conversation

@marvin-hansen

@marvin-hansen marvin-hansen commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Describe your changes

ci: gate releases on a publishable-workspace check

Issue ticket number and link

Code checklist before requesting a review

  • I have signed the DCO?
  • All tests are passing when running make test?
  • No errors or security vulnerabilities are reported by make check?

For details on make, please see BUILD.md

Note: The CI runs all of the above and fixing things before they hit CI speeds
up the review and merge process. Thank you.


Summary by cubic

Adds a release pre-flight that blocks merges when the workspace can't be published, so a release never fails halfway leaving crates half-released.

A new GitHub Actions workflow gates both checks on every PR and push to main, and make check_publishable runs them locally. The dev-dependency check queries the crates.io index to confirm every versioned internal dev-dependency requirement is already published — the subset a dry run structurally cannot see — and the dry-run packages and builds all 33 crates from their own .crate archives, catching missing files, broken exclude rules, and build failures. Non-caret requirements fail the check rather than being guessed at, and an empty edge list is treated as an error.

Written for commit 8deb09d. Summary will update on new commits.

Review in cubic

Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
@marvin-hansen marvin-hansen self-assigned this Sep 25, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found and verified against the latest diff

You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="deep_causality_utils/deep_causality_tempfile/CHANGELOG.md">

<violation number="1" location="deep_causality_utils/deep_causality_tempfile/CHANGELOG.md:8">
P3: This file now ends without a trailing newline (the editor wrote `\ No newline at end of file`). Every other CHANGELOG.md in the repo ends with `\n`. Add the trailing newline; it also keeps the file POSIX-conformant and avoids markdownlint MD047 failures.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/rust_publish_check.yml Outdated
Comment thread scripts/check_dev_deps.sh
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased] No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This file now ends without a trailing newline (the editor wrote \ No newline at end of file). Every other CHANGELOG.md in the repo ends with \n. Add the trailing newline; it also keeps the file POSIX-conformant and avoids markdownlint MD047 failures.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At deep_causality_utils/deep_causality_tempfile/CHANGELOG.md, line 8:

<comment>This file now ends without a trailing newline (the editor wrote `\ No newline at end of file`). Every other CHANGELOG.md in the repo ends with `\n`. Add the trailing newline; it also keeps the file POSIX-conformant and avoids markdownlint MD047 failures.</comment>

<file context>
@@ -4,3 +4,5 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
\ No newline at end of file
</file context>
Suggested change
## [Unreleased]
## [Unreleased]

@marvin-hansen
marvin-hansen merged commit 1be0d2b into deepcausality-rs:main Sep 25, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant