fix(tlv): revert mute handling fix for MINMAX_MUTE type - #14
Open
deepin-ci-robot wants to merge 1 commit into
Open
fix(tlv): revert mute handling fix for MINMAX_MUTE type#14deepin-ci-robot wants to merge 1 commit into
deepin-ci-robot wants to merge 1 commit into
Conversation
This reverts commit 41039b49ad3e20506134864028c77aeaba4c0d51. SND_CTL_TLVT_DB_MINMAX_MUTE means that the hardware is muted on lowest hardware volume value (not on lowest dB value). Changes: - Add debian/patches/fix-tlv-revert-mute-handling-minmax-mute.patch - Modify debian/patches/series - Modify debian/changelog Upstream: alsa-project/alsa-lib@96f23dd Generated-By: glm-5.2 Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 1.2.15.3-1deepin8 |
Member
|
我给上游改错了，上游后来发现并进行了 revert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
The previous upstream commit 41039b49 ("snd_tlv_convert_to_dB: Fix mute
handling for MINMAX_MUTE type") introduced a regression: volume values
above the minimum but whose computed dB equals the minimum dB were
incorrectly reported as MUTE. This affects controls using the
SND_CTL_TLVT_DB_MINMAX_MUTETLV type, where the hardware is muted onlyat the lowest hardware volume value (not the lowest dB value).
What This PR Changes
Reverts upstream commit 41039b49, restoring the original
snd_tlv_convert_to_dB()behavior that mutes only whenvolume <= rangemin(or the range is empty) forMINMAX_MUTEtype, andreports the proper interpolated dB value for all other volume levels.
Problem Solved After the Change
Volume values above the minimum now report correct dB values instead of
being incorrectly muted, matching the expected hardware behavior for
SND_CTL_TLVT_DB_MINMAX_MUTEcontrols.Changes
Upstream
alsa-project/alsa-lib@96f23dd
Generated-By: glm-5.2
Co-Authored-By: deepin-ci-robot packages@deepin.org