fix(network): also remove address on cancelling request - #413
Open
deepin-ci-robot wants to merge 1 commit into
Open
Conversation
Otherwise, the address may arrive after we call link_drop_foreign_address() or so on reconfiguring interface. Changes: - Add debian/patches/fix-network-remove-address-on-cancelling-request.patch - Modify debian/patches/series - Modify debian/changelog Upstream: systemd/systemd@4303e98 Generated-By: glm-5.3-flash Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 255.2-4deepin68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
When a network interface is reconfigured, pending address requests are cancelled via
link_drop_requests(), but the address itself was not removed. If a request had already been sent to the kernel and was waiting for its netlink reply, the address could still arrive afterlink_drop_foreign_address()ran, leaving a stale/unexpected IP address configured on the interface.What This PR Changes
Backport of upstream systemd commit 4303e9806b:
link_drop_requests()now returns an error code, and when a cancelled request is already waiting for its reply (and the link is not inLINK_STATE_LINGER), it explicitly removes the address forREQUEST_TYPE_ADDRESSrequests. The gathered result is propagated inlink_reconfigure_impl()andlink_drop().Problem Solved After the Change
Cancelled address requests no longer leave behind addresses that arrive after the drop, so interface reconfiguration is deterministic and no stale addresses remain.
Changes
Upstream
systemd/systemd@4303e98 (upstream PR #30716)
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org